rngtest, run-test.sh: Robust error handling, dependency SKIP, and summary improvements #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rngtest/run.sh: Use dd to source entropy data for more reliable testing, improve output parsing, and enhance error handling for missing or malformed rngtest output. - run-test.sh: Detect and report SKIP results in test summary by parsing .res files, so that SKIPped tests are no longer counted as pass or fail. - Print SKIPPED section in summary for clearer CI/test visibility. - Ensures correct reporting of pass, fail, and skip for all test cases, and makes rngtest reliable across platforms. Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
abbajaj806
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the Kernel rngtest test script and the main run-test.sh runner with several reliability, logging, and error-handling improvements:
rngtest/run.sh:
ddinstead ofcatto reliably generate input entropy, preventing hangs or input depletion from/dev/random.rngtestanddd) and SKIP logic if binaries are missing.run-test.sh:
Together, these changes ensure test results reflect true execution status and failures, reduce flakiness in CI, and allow for more consistent debugging and summary reporting.
Tested on multiple setups with and without missing dependencies, and confirmed proper SKIP and summary behavior.